Skip to content

Conversation

@nemanjaASE
Copy link
Contributor

This pull request adds type annotations to several functions and methods in the codebase where they were previously missing. This improves code readability, makes the expected input and output types clearer, and helps with static type checking.

Changes include:

  • - Type annotations added for function arguments and return values.

These additions will assist in better integration with static type checkers and contribute to overall code quality.

@codebeaver-ai
Copy link

codebeaver-ai bot commented Mar 9, 2025

I opened a Pull Request with the following:

🔄 4 test files added.
🐛 No bugs detected in your changes
🛠️ 0/0 tests passed

🔄 Test Updates

I've added 4 tests. They all pass ☑️
New Tests:

  • agentic_security/core/test_app.py
  • agentic_security/probe_actor/test_refusal.py
  • tests/test_report_chart.py
  • tests/test_scan.py

No existing tests required updates.

🐛 Bug Detection

No bugs detected in your changes. Good job!

☂️ Coverage Improvements

Coverage improvements by file:

  • agentic_security/core/test_app.py

    New coverage: 100.00%
    Improvement: +34.29%

  • agentic_security/probe_actor/test_refusal.py

    New coverage: 96.30%
    Improvement: +11.11%

  • tests/test_report_chart.py

    New coverage: 100.00%
    Improvement: +100.00%

  • tests/test_scan.py

    New coverage: 79.55%
    Improvement: +79.55%

🎨 Final Touches

  • I ran the hooks included in the pre-commit config.

Settings | Logs | CodeBeaver

@codebeaver-ai
Copy link

codebeaver-ai bot commented Mar 9, 2025

I opened a Pull Request with the following:

🔄 4 test files added.
🐛 No bugs detected in your changes
🛠️ 0/0 tests passed

🔄 Test Updates

I've added 4 tests. They all pass ☑️
New Tests:

  • agentic_security/core/test_app.py
  • agentic_security/probe_actor/test_refusal.py
  • tests/test_report_chart.py
  • tests/test_scan.py

No existing tests required updates.

🐛 Bug Detection

No bugs detected in your changes. Good job!

☂️ Coverage Improvements

Coverage improvements by file:

  • agentic_security/core/test_app.py

    New coverage: 100.00%
    Improvement: +35.29%

  • agentic_security/probe_actor/test_refusal.py

    New coverage: 96.30%
    Improvement: +11.11%

  • tests/test_report_chart.py

    New coverage: 100.00%
    Improvement: +100.00%

  • tests/test_scan.py

    New coverage: 97.78%
    Improvement: +97.78%

🎨 Final Touches

  • I ran the hooks included in the pre-commit config.

Settings | Logs | CodeBeaver

@msoedov
Copy link
Owner

msoedov commented Mar 9, 2025

Hi @nemanjaASE! Thanks again for another awesome pull request to agentic-security. Your work on PR is greatly appreciated, as always. It’s fantastic to see your continued support and contributions to the project. I really appreciate it

@msoedov msoedov merged commit 02222b7 into msoedov:main Mar 9, 2025
5 of 6 checks passed
@nemanjaASE nemanjaASE deleted the issue-158-missing-type-annotations branch March 9, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants